Merged
Conversation
MinYeongPark
reviewed
Feb 6, 2024
Member
MinYeongPark
left a comment
MinYeongPark
left a comment
There was a problem hiding this comment.
고생하셨습니다!👍
RequestHeader에 atk 추가해주시면 좋을 것 같아서 수정하는 제안 추가해봤는데 반영해주시면 감사하겠습니다!
| }) | ||
| private ApiResponse<AlarmResponseDTO.AlarmListResDTO> getAlarm( | ||
| @RequestHeader(name = "id") Long userId, | ||
| HttpServletRequest request, |
Member
There was a problem hiding this comment.
앗 swagger에서 RequestHeader에 atk 가 떠야 해서, HttpServletRequest request, 위쪽 줄에
@RequestHeader(name = "atk") String atk,
도 같이 추가해주시면 좋을 것 같아요!
MinYeongPark
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.