Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch19368]: fix docx files detect as application/zip #1

Merged
merged 2 commits into from
Dec 1, 2020
Merged

[ch19368]: fix docx files detect as application/zip #1

merged 2 commits into from
Dec 1, 2020

Conversation

Strafi
Copy link

@Strafi Strafi commented Dec 1, 2020

No description provided.

@Strafi Strafi requested a review from Strangerxxx December 1, 2020 09:18
@Strafi Strafi self-assigned this Dec 1, 2020
Strangerxxx
Strangerxxx requested changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@Strangerxxx Strangerxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's shrink size of the big one fixture and rename pull-request according to clubhouse task

.gitignore Outdated Show resolved Hide resolved
@Strafi Strafi changed the title Update magic file to properly determine docx files and add tests [ch19368]: Investigate: Desktop: .docx file has MIMEtype:application/zip Dec 1, 2020
@Strafi Strafi requested a review from Strangerxxx December 1, 2020 09:54
@Strangerxxx Strangerxxx changed the title [ch19368]: Investigate: Desktop: .docx file has MIMEtype:application/zip [ch19368]: fix .docx files detect as application/zip Dec 1, 2020
@Strangerxxx Strangerxxx changed the title [ch19368]: fix .docx files detect as application/zip [ch19368]: fix docx files detect as application/zip Dec 1, 2020
Strangerxxx
Strangerxxx approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@Strangerxxx Strangerxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Strafi Strafi merged commit ce1058c into master Dec 1, 2020
@Strangerxxx Strangerxxx mentioned this pull request Dec 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strangerxxx Strangerxxx Strangerxxx approved these changes

Assignees

@Strafi Strafi

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strafi @Strangerxxx