Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rails gem dependencies to use Rails v7 #62

Merged
3 commits merged into from
May 27, 2024
Merged

Conversation

alto
Copy link
Member

@alto alto commented Aug 30, 2023

Description

We want to upgrade to Rails 7.0, flappi has a dependency to activesupport. In addition to that, the latest minitest doesn't support the old namespace MiniTest anymore, it's Minitest now.

See Asana ticket for the Rails 7 upgrade.


We want to upgrade to Rails 7.0, `flappi` has a dependency to `activesupport`. In addition to that, the latest `minitest` doesn't support the old namespace `MiniTest` anymore, it's `Minitest` now.

See [Asana ticket](https://app.asana.com/0/1202529446124723/1202529446124728) for the Rails 7 upgrade.
@alto alto added the Ready for Code Review In the process of, or in need of, a Code Review label Aug 30, 2023
@alto alto self-assigned this Aug 30, 2023
@alto alto marked this pull request as ready for review April 30, 2024 23:29
@alto alto requested a review from fsanggang April 30, 2024 23:29
Copy link
Contributor

@fsanggang fsanggang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alto alto added On Testing and removed Ready for Code Review In the process of, or in need of, a Code Review labels May 16, 2024
@alto alto closed this pull request by merging all changes into master in 1618ffa May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants