Bump to ruby 3.3.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve error: ``` Error: RuboCop found unknown Ruby version 3.3 in `.ruby-version`. Supported versions: 2.5, 2.6, 2.7, 3.0, 3.1 ``` https://app.asana.com/0/1205428368058391/1206747143442456/f
Redundant because: - nil.to_i #=> 0 - A.to_i #=> 0 https://app.asana.com/0/1205428368058391/1206747143994466/f
Due to errors observed like:
```
home/runner/work/flappi/flappi/test/api_doc_formatter_test.rb:5:in `<top (required)>': uninitialized constant MiniTest (NameError)
class ::Flappi::ApiDocFormatterTest < MiniTest::Test
^^^^^^^^
Did you mean? Minitest
Maxitest
from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
from /home/runner/work/flappi/flappi/vendor/bundle/ruby/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:21:in `block in <main>'
from /home/runner/work/flappi/flappi/vendor/bundle/ruby/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `select'
from /home/runner/work/flappi/flappi/vendor/bundle/ruby/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `<main>'
```
This is because maxitest began using Minitest instead of MiniTest in v5.3.1:
grosser/maxitest@v5.3.0...v5.3.1
Ideally we should update so it will work with maxitest v5, in our other gems we fix to ~> 4.
So, just do the same here for now, and maybe update from MiniTest -> Minitest later.
https://app.asana.com/0/1205428368058391/1206747143994466/f
fsanggang
added
the
Ready for Code Review
https://app.asana.com/0/1205428368058391/1206747143994466/f Co-authored-by: Thorsten Böttger <boettger@mt7.de>
fsanggang
added
On Testing
and removed
Ready for Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There are some
rubocop-related changes also, so this might be easier to review commit by commit. (But honestly, they are mostly just ignoring the same rules we already ignore in Investapp).