-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe Connect Onboarding - base branch #1234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
changed the title
Stripe Connect Onboarding
Stripe Connect Onboarding - base branch
Dec 2, 2019
OtterleyW
force-pushed
the
stripe-connect-onboarding
branch
from
December 3, 2019 08:57
3a6ffa4
to
0970f11
Compare
Accidentally closed the branch when I rebased the master and there were no new commits yet. The branch should be open again when we add new commits here. |
OtterleyW
force-pushed
the
stripe-connect-onboarding
branch
from
December 17, 2019 15:42
3a872bd
to
64b3d4b
Compare
OtterleyW
force-pushed
the
stripe-connect-onboarding
branch
from
December 19, 2019 07:58
aa39457
to
a107a7e
Compare
OtterleyW
force-pushed
the
stripe-connect-onboarding
branch
from
December 20, 2019 08:28
a107a7e
to
cfffbdd
Compare
OtterleyW
force-pushed
the
stripe-connect-onboarding
branch
from
December 20, 2019 08:31
cfffbdd
to
c4b1eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Stripe Connect onboarding flow in FTW
In this update, we have taken into use Stripe's Connect onboarding. Through the Connect onboarding Stripe will securely collect sensitive personal details and ID documents needed for verification, and handle updates to the UI to meet changing compliance requirements. On FTW we need to handle creating new Stripe accounts and saving information about the external accounts (e.g. IBAN number) to the user's Stripe account.
After this update users can also update most of the information through the Connect onboarding. Updating the external account is also possible and done through the Flex API directly.
You can read more form How to handle provider onboarding and identity verification on FTW guide.
Changes:
stripeConnectAccount.duck.js
which handles creating and updating the Stripe accounts and creating the Account Link where the users get redirectedStripePayoutPage
which replaces the oldPayoutPreferencesPage
StripeConnectAccountForm
which replaces the oldPayoutDetailsForm
onStripePayoutPage
and onEditListingPage
On the
EditListingPage
, the modal withStripeConnectAccountForm
is shown if the user doesn't have a Stripe account yet or if there is some information missing from the account. The modal will be shown only if the user is publishing the listing so currently, users can update already published listing even if their Stripe account is restricted.Removed components
Because of this change, we have deprecated the old
PayoutDetailsForm
andPayoutPreferencesPage
. Also functions related to deprecated form has been removed fromstripe.duck.js
. If you want to keep using the custom form in your own application, you can take these deprecated components as a starting point but you should keep in mind that they will not be updated by our team. This means you need to take care that you collect all the required information and somehow take care that it's possible to fill in information if that's needed later.You can find the deprecated files still from v.3.7.0
PayoutDetailsForm
PayoutPreferencesPage
stripe.duck.js
.Connect onboarding flow
Creating or updating the Stripe account
=>
sdk.stripeAccount.create
Create a new Stripe account with
country
andbankAccountToken
.OR
=>
sdk.stripeAccount.update
Update the Stripe account with
bankAccountToken
.Fetching the information about Stripe account
=>
sdk.stripeAccount.fetch
If the user already has the Stripe account you need to fetch the up-to-date account data from the API. This same data is returned after create and update Stripe account API calls.
Creating Account Link
=>
sdk.stripeAccountLink.create
Depending on the status of the Stripe account we will show
StripeConnectAccountStatusBox
with "Get verified" or "Edit Stripe account link". When the user clicks the link, a new Account Link is created and the user is redirected to StripeWhen the user returns to the application we need to check the URL parameter of the return URL.
verificationSuccess
modeverificationNeeded
modeverificationError
mode