Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searchMode in new URL after map is changed #1441

Closed
wants to merge 1 commit into from
Closed

Fix searchMode in new URL after map is changed #1441

wants to merge 1 commit into from

Conversation

anh-dinh-jh
Copy link
Contributor

This PR is used to:

  • Keep the existing applied searchMode in a newly created URL when the bounds of a map is changed on SearchPage

@Gnito Gnito mentioned this pull request May 28, 2021
Merged
@Gnito
Copy link
Contributor

Gnito commented May 28, 2021

@anh-dinh-jh nice catch and thanks for the pull request!
I used your commit, but added couple of extra commits in a separate PR.
(I used Prettier formatting and added a changelog entry.)

#1443
I'm closing this PR in favor of that one.

@Gnito Gnito closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anh-dinh-jh @Gnito