Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regroup examples in styleguide #14

Merged
merged 11 commits into from
Mar 29, 2021
Merged

Regroup examples in styleguide #14

merged 11 commits into from
Mar 29, 2021

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented Mar 23, 2021

Screenshot 2021-03-23 at 20 53 13

  • merge group custom inputs to inputs
  • Remove references to lorempixel
  • Rename payment methods group as payments. Add BookingBreakdown and BookingPanel there too
  • Move Footer from misc to sections
  • New group: reviews
  • New group: images (ImageCarousel & ResponsiveImage)
  • Support prefixed groups
  • Use "page:" prefix for page-related components
  • Move "autoFocus" prop to EditListingWizard panels from forms. (Just to avoid jumps in styleguide.)

@Gnito Gnito changed the title Refactor examples Regroup examples in styleguide Mar 23, 2021
@Gnito Gnito merged commit 61d46cf into main Mar 29, 2021
@Gnito Gnito deleted the refactor-examples branch March 29, 2021 11:53
Copy link
Contributor

@kpuputti kpuputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just submitting this review as I had written this one comment earlier.

},
'square-small2x': {
name: 'square-small2x',
width: 480,
height: 480,
url: 'https://lorempixel.com/480/480/people/',
url: 'https://via.placeholder.com/480x480',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The faces were kinda nice, but ok :/

Just getting rid of a domain in CSP is a good reason to do this, so not opposing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants