Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle status comment IDs greater than i32 #186

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Handle status comment IDs greater than i32 #186

merged 2 commits into from
Jun 5, 2024

Conversation

Srynetix
Copy link
Contributor

@Srynetix Srynetix commented Jun 5, 2024

Also:

  • Lock Rust version to 1.78.0
  • Fix new clippy lints

@Srynetix Srynetix self-assigned this Jun 5, 2024
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9387644744

Details

  • 18 of 25 (72.0%) changed or added relevant lines in 13 files are covered.
  • 204 unchanged lines in 57 files lost coverage.
  • Overall coverage decreased (-0.2%) to 75.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/prbot-database-tests/src/testcase.rs 1 2 50.0%
crates/prbot-ghapi-interface/src/types/reviews/review_state.rs 0 2 0.0%
crates/prbot-models/src/checks_status.rs 0 2 0.0%
crates/prbot-models/src/step_label.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
crates/prbot-core/src/use_cases/pulls/add_pull_request_rule.rs 1 7.69%
crates/prbot-core/src/bot_commands/commands/admin/admin_set_default_reviewers.rs 1 0.0%
crates/prbot/src/commands/repository/pull_request_rule/mod.rs 1 0.0%
crates/prbot-server/src/webhook/pulls.rs 1 18.75%
crates/prbot-core/src/bot_commands/commands/admin/admin_set_pr_reviewers.rs 1 0.0%
crates/prbot-core/src/bot_commands/commands/user/set_automerge.rs 1 0.0%
crates/prbot-server/src/external/status.rs 1 0.0%
crates/prbot-core/src/bot_commands/commands/admin/admin_set_default_automerge.rs 1 0.0%
crates/prbot/src/commands/debug/mod.rs 1 0.0%
crates/prbot/src/commands/server.rs 1 0.0%
Totals Coverage Status
Change from base Build 8550677301: -0.2%
Covered Lines: 12984
Relevant Lines: 17152

💛 - Coveralls

@Srynetix Srynetix merged commit 6e7d7ac into main Jun 5, 2024
1 check passed
@Srynetix Srynetix deleted the duplicates branch June 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants