Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect NO_COLOR environment variable #1021

Closed
sharkdp opened this issue May 24, 2020 · 2 comments
Closed

Respect NO_COLOR environment variable #1021

sharkdp opened this issue May 24, 2020 · 2 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@sharkdp
Copy link
Owner

sharkdp commented May 24, 2020 •
edited
Loading

Even if it might seem that using bat without colors doesn't make too much sense, we should probably respect the NO_COLOR environment variable. There might be situations (bat is used inside another program and the user doesn't even know about it) where it could be useful.

Spec: https://no-color.org/
See similar implementation in fd: https://github.com/sharkdp/fd/pull/551/files (but note: sharkdp/fd#600)
@sharkdp sharkdp added feature-request New feature or request good first issue Good for newcomers labels May 24, 2020
eth-p added a commit to eth-p/bat that referenced this issue May 27, 2020
@eth-p
Add support for NO_COLOR env var (sharkdp#1021)
96b92a8
eth-p added a commit to eth-p/bat that referenced this issue May 27, 2020
@eth-p
Add support for NO_COLOR env var (sharkdp#1021)
c638de4
sharkdp pushed a commit that referenced this issue May 28, 2020
@eth-p @sharkdp
Add support for NO_COLOR env var (#1021)
8b481dd
@sharkdp sharkdp closed this as completed Jul 25, 2020
@sharkdp
Copy link
Owner Author

sharkdp commented Oct 2, 2020

Released in v0.16.0.

1 similar comment
@sharkdp
Copy link
Owner Author

sharkdp commented Oct 2, 2020

Released in v0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharkdp