Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver-parser sub-dependency not compatible with current MSRV without lockfile #1477

Closed
niklasmohrin opened this issue Jan 5, 2021 · 3 comments · Fixed by #1495
Closed
Labels
bug Something isn't working

Comments

@niklasmohrin
Copy link
Contributor

bat cannot be built with Rust 1.40 without passing the --locked flag. This is because the semver dependency has semver-parser as a dependency and this crate started using a new feature in a minor version patch (v0.10.1) that is available only from Rust 1.44 onwards. The lockfile on the master branch has semvar-parser locked at v0.10.0 which still compiles. To reproduce, run

$ rm Cargo.lock
$ rustup default 1.40
$ cargo b

To eliminate this issue, the version of the sub dependency can be held in place as done here or the MSRV of bat could be lifted to 1.44.

I encountered this problem first in this PR where I added a new dependency and wanted to ship a fresh lockfile with the addition, but the MSRV CI runner failed due to this.

This is all assuming you see this as an issue in the first place, after all the build instructions tell you to use the --locked flag, as sharkdp pointed out under the aforementioned PR.

@niklasmohrin niklasmohrin added the bug Something isn't working label Jan 5, 2021
@steveklabnik
Copy link

I've pushed a new patch version of semver-parser so this should just be fixed, I believe.

@niklasmohrin
Copy link
Contributor Author

Awesome, thank you very much! This fixes the probem without any changes needed here.

@sharkdp Should the Cargo.toml be updated to use version v0.10.2 and a new lockfile be generated still?

@sharkdp
Copy link
Owner

sharkdp commented Jan 8, 2021

@sharkdp Should the Cargo.toml be updated to use version v0.10.2 and a new lockfile be generated still?

That's probably a good idea - thanks!

sharkdp added a commit that referenced this issue Jan 9, 2021
sharkdp added a commit that referenced this issue Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants