Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to pass arguments to the pager via PAGER / BAT_PAGER #352

Closed
sharkdp opened this issue Oct 11, 2018 · 2 comments
Closed

Add a way to pass arguments to the pager via PAGER / BAT_PAGER #352

sharkdp opened this issue Oct 11, 2018 · 2 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@sharkdp
Copy link
Owner

sharkdp commented Oct 11, 2018

We can use a function to split a (simple) shell command-line into multiple arguments. This would allow use to use just

BAT_PAGER="less --tabs 4 -RF"

instead of using a wrapper script.

This could be useful: https://crates.io/crates/shell-words
@sharkdp sharkdp added feature-request New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 11, 2018
@sharkdp sharkdp changed the title Add a way to pass command-line arguments via PAGER / BAT_PAGER Add a way to pass arguments to the pager via PAGER / BAT_PAGER Oct 11, 2018
@Foxboron
Copy link
Contributor

Taking a stab at this one :)

Foxboron added a commit to Foxboron/bat that referenced this issue Oct 12, 2018
@Foxboron
Add arguments from PAGER/BAT_PAGER
501a5d7 
Solves sharkdp#352

Signed-off-by: Morten Linderud <morten@linderud.pw>
@Foxboron Foxboron mentioned this issue Oct 12, 2018
Merged
Foxboron added a commit to Foxboron/bat that referenced this issue Oct 14, 2018
@Foxboron
Add arguments from PAGER/BAT_PAGER
17c2d56 
Solves sharkdp#352

Signed-off-by: Morten Linderud <morten@linderud.pw>
sharkdp pushed a commit to Foxboron/bat that referenced this issue Oct 17, 2018
@Foxboron @sharkdp
Add arguments from PAGER/BAT_PAGER
dcc5c19 
Solves sharkdp#352

Signed-off-by: Morten Linderud <morten@linderud.pw>
sharkdp pushed a commit that referenced this issue Oct 17, 2018
@Foxboron @sharkdp
Add arguments from PAGER/BAT_PAGER
67fe833 
Solves #352

Signed-off-by: Morten Linderud <morten@linderud.pw>
@sharkdp sharkdp closed this as completed Oct 17, 2018
@sharkdp
Copy link
Owner Author

sharkdp commented Oct 17, 2018

Released in v0.8.0.

@sharkdp sharkdp mentioned this issue Nov 14, 2018
Closed
@cohml cohml mentioned this issue Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Foxboron @sharkdp