Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bat 0.13 release #845

Closed
14 tasks done
sharkdp opened this issue Feb 28, 2020 · 9 comments
Closed
14 tasks done

bat 0.13 release #845

sharkdp opened this issue Feb 28, 2020 · 9 comments
Labels
help wanted Extra attention is needed packaging/tooling
Milestone

Comments

@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2020

Changes since 0.12.1: v0.12.1...master

  • Write release notes (according to the usual format https://github.com/sharkdp/bat/releases/tag/v0.12.0)
  • Check for outdated dependencies (https://deps.rs/repo/github/sharkdp/bat)
  • Run cargo update to update dependencies to the latest compatible (minor) version.
  • Run cargo fmt
  • Update syntaxes and themes (assets/create.sh).
  • Update README (features, usage, languages, ..).
  • Update man page.
  • Review -h/--help text.
  • Update version in Cargo.toml. Run cargo build to update Cargo.lock. Update the version in all README files (translations).
  • Run cargo install -f --path . and locally test the new release
  • cargo publish --dry-run --allow-dirty.
  • git tag vX.Y.Z; git push --tags
  • publish to crates.io by cloning a fresh repo and calling cargo publish.
  • Inform package maintainers about the update:

See also: My release checklist for Rust programs

@sharkdp
Copy link
Owner Author

sharkdp commented Mar 6, 2020

I have added a few tickets to the v0.13 milestone. Let's try to work on these before releasing v0.13:

https://github.com/sharkdp/bat/milestone/6

@sharkdp sharkdp added this to the v0.13 milestone Mar 6, 2020
@wookietreiber
Copy link

@sharkdp I just stumbled upon your checklist -- just wanted to let you know that on Arch Linux bat has moved from AUR to the community repo.

@sharkdp
Copy link
Owner Author

sharkdp commented Mar 18, 2020

Oh right, the checklist is outdated. We already link to the correct package in the README: https://github.com/sharkdp/bat#on-arch-linux

Updating the checklist...

This was referenced Mar 19, 2020
sharkdp added a commit to neuronull/bat that referenced this issue Mar 22, 2020
sharkdp added a commit to neuronull/bat that referenced this issue Mar 22, 2020
sharkdp added a commit that referenced this issue Mar 22, 2020
sharkdp added a commit that referenced this issue Mar 22, 2020
@sharkdp
Copy link
Owner Author

sharkdp commented Mar 22, 2020

v0.13 has been released: https://github.com/sharkdp/bat/releases/tag/v0.13.0

@sharkdp sharkdp closed this as completed Mar 22, 2020
@ignatenkobrain
Copy link
Contributor

@sharkdp would be nice if you could inform me too since I'm packaging bat for Fedora.

@sharkdp
Copy link
Owner Author

sharkdp commented Mar 22, 2020

@sharkdp would be nice if you could inform me too since I'm packaging bat for Fedora.

Will do, added to my checklist for future releases. Thank you very much for your work!

@sharkdp sharkdp unpinned this issue Mar 22, 2020
@pizzamig
Copy link

Hi. I'm the package maintainer for FreeBSD. Thanks for your amazing project.
I've a small issue with man page installation.
In 0.13 the man page [and the shell completion files that I want to add to the package] are now generated from a template during the build phase, it's not installed/copied via cargo install, it's buried in the target folder (something like target/release/build/bat-0e2b1a64c228c1b3/out/assets/. with the bat folder that contains a hash (I don't know how is generated and how often it will change).
Is there a way to install those artifacts during cargo install or deterministically know the path for those files outside cargo?

@sharkdp
Copy link
Owner Author

sharkdp commented Mar 24, 2020

@pizzamig Thank you for the feedback and for your work!

We have the same problem when building the Debian packages in CI. We actually use a * glob to get around this:

cp target/"$TARGET"/release/build/"$PROJECT_NAME"-*/out/assets/manual/bat.1 "$tempdir/$package_name/$PROJECT_NAME.1"

This is obviously not a great solution, but I don't really know if there is a better way :-/

@pizzamig
Copy link

I'm testing find target -name bat.1 -exec cp {} $DESTDIFR \; and it seems to work,
I guess it's something missing from cargo, the extra artifacts are not installed with cargo install and there is no way to tell cargo about them...
Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed packaging/tooling
Projects
None yet
Development

No branches or pull requests

4 participants