Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AsciiDoc syntax submodule #1034

Merged
merged 1 commit into from
May 29, 2020
Merged

Updated AsciiDoc syntax submodule #1034

merged 1 commit into from
May 29, 2020

Conversation

rxt1077
Copy link
Contributor

@rxt1077 rxt1077 commented May 29, 2020

I've updated the AsciiDoc syntax to a newer version (from the AsciiDoctor project) which happens to work with fancy-regex. My problem originally was that nushell was crashing when I tried to open adoc files. I found that they get their syntax from here.

I wholeheartedly agree with the discussion in this issue BTW: #919, consolidation might make things easier.

@sharkdp
Copy link
Owner

sharkdp commented May 29, 2020

We do not use fancy-regex in bat, and I don't think that it's a good idea that nushell uses bats binary syntax dump (which was built with onig enabled) with the fancy-regex feature of syntect. They will experience panics for multiple syntaxes. I have documented some of these incompatibilities here: trishume/syntect#287. See also: #650 (comment)

So for bat, there's not really any need to update the AsciiDoc syntax. That being said, it looks like the alternative syntax proposed here is more complete? Could you comment on that?

@rxt1077
Copy link
Contributor Author

rxt1077 commented May 29, 2020

Thank you for the links and the background. I was unaware of the issues with nushell's usage.

Concerning how this version can benefit bat, this syntax is updated and more complete than the previous syntax. It looks like the previous syntax was a bit of a work in progress, whereas this one has been maintained to some extent by a larger project (AsciiDoctor).

@sharkdp sharkdp merged commit 268c096 into sharkdp:master May 29, 2020
@sharkdp
Copy link
Owner

sharkdp commented May 29, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants