Add Svelte as a syntax

[kjmph]

Another syntax definition that is helpful for bat to incorporate.

[eth-p]

Before we add built-in syntaxes to bat, they need to meet a minimum requirement of installs on PackageControl.

Here are the metrics I found:

• PackageControl - 4k
• Atom (1) - 6.6k
• Atom (2) - 144
• JetBrains - 37k

While the only metric we go by currently is PackageControl (dicussion: #1262), the number of JetBrains installs easily triples our minimum criteria... @sharkdp, @keith-hall: thoughts?

[kjmph]

Thanks, let me know if I can help. Btw, when you say "add built-in syntaxes," should I interpret that there is a way to have syntaxes added via plugins, and not as a submodule?

[keith-hall]

Interesting that the syntax is most popular with JetBeans :) nice detective work, @eth-p. I say we can allow it.

Btw, when you say "add built-in syntaxes," should I interpret that there is a way to have syntaxes added via plugins, and not as a submodule?

@kjmph It is possible to customize bat to use syntax definitions not included by default in the installation. Here we are just discussing whether we want Svelte included in the installation by default. Having a plugin system to provide more syntaxes is something we are actively discussing, but doesn't exist yet.

[kjmph]

Ahh, I see now. I'll change my workflow and start using the cache build more effectively. Thanks for that pointer.

[sharkdp]

the number of JetBrains installs easily triples our minimum criteria...

Ok, but I don't think these numbers are comparable. Maybe JetBrains auto-downloads the syntax package every month for update checks (just as an example). Or maybe there are much more or much less JetBrains users compared to Sublime users.

On the other hand, I think there are definitely some syntaxes that would not make sense for Sublime Text users to install.. but would still be very valuable for bat. A stupid example would be the /proc/cpuinfo syntax. Another example might be a syntax for a language that comes with its own de-facto IDE. Something like Mathematica comes to mind.

Anyhow.. I understand we want to merge this. @kjmph Thank you very much for your contribution!

Could you please add an entry to the "unreleased" section in CHANGELOG.md? The format for entries is:

- Description what has been changed, see #123 (@user)

where #123 links to the bug ticket and/or the PR and user is your username.

[kjmph]

My apologies on the delay. I believe the latest commit takes care of the Changelog request.

[sharkdp]

@kjmph Thank you for the update. I'm happy to merge this if we can also add a syntax regression test along the lines of #1213.

We should document this as a requirement for future syntax additions.

[kjmph]

I believe this latest commit takes care of the regression syntax test.

[sharkdp]

Thank you!

[sharkdp]

Added in bat v0.17.