fix some clippy warnings

[MarcoIeni]

No description provided.

[MarcoIeni]

It looks like the matches! macro was introduced in rust 1.42.
We can either:

• increase minimum rust version to 1.42
• revert the changes regarding the matches! macro and opt out those clippy warnings in order to never appear again when you run cargo clippy

[eth-p]

I like most of these changes, but I'm not a fan of using matches! everywhere. It has its uses, but I find it makes it harder to immediately understand what's happening. It's also not something I would consider worth bumping the minimum version for.

I've seen other projects disable that Clippy rule, and I would be in favor of doing it for bat. @sharkdp @keith-hall, your thoughts?

[MarcoIeni]

Ok, so both eth-p and sharkdp seems to agree they want to go for option 2:

• revert the changes regarding the matches! macro and opt out those clippy warnings in order to never appear again when you run cargo clippy

If you confirm that I will do it :)

[sharkdp]

Ok, so both eth-p and sharkdp seems to agree they want to go for option 2:

• revert the changes regarding the matches! macro and opt out those clippy warnings in order to never appear again when you run cargo clippy

If you confirm that I will do it :)

I'd rather not add any clippy-annotations.

If we can keep backwards compatibility for now, that would be great.

[MarcoIeni]

I'd rather not add any clippy-annotations.

Why? If we add them we can add clippy to the CI.

[sharkdp]

Thank you!

[sharkdp]

I'd rather not add any clippy-annotations.

Why? If we add them we can add clippy to the CI.

I don't want to force contributors to fix clippy suggestions in order to get a successful CI build.