Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ruby-slim syntax #1694

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Add support for ruby-slim syntax #1694

merged 3 commits into from
Aug 16, 2021

Conversation

mfinelli
Copy link
Contributor

Resolves #1693

@sharkdp
Copy link
Owner

sharkdp commented Jul 25, 2021

Thank you for your contribution. Could you please rebase this PR and move the CHANGELOG line to the "unreleased" section? It got moved down when I released a new bat version recently.

@keith-hall
Copy link
Collaborator

This submodule is missing a sublime-syntax file. Please follow the instructions to add one by converting the tmLanguage file, while leaving the submodule intact. https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting

@mfinelli
Copy link
Contributor Author

@keith-hall thanks, I've generated the slim-syntax as in the guide with a test plus rebased onto the latest master

@keith-hall keith-hall added submodules Pull requests that update Submodules code and removed needs-work labels Aug 15, 2021
Copy link
Collaborator

@keith-hall keith-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@sharkdp sharkdp merged commit 699f1e6 into sharkdp:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ruby slim-lang syntax support
3 participants