HighlightingAssets: Encapsulate theme_set behind a getter #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
commented
Jul 29, 2021
sharkdp
approved these changes
Jul 29, 2021
Mainly to prepare for potential lazy-loading in the future to improve startup performance. Like we did for syntax_set.
Enselic
force-pushed
the
encapsulate-theme-set
branch
from
add5c99
to
85b2e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to prepare for potential lazy-loading in the future to improve startup performance. Like we did for
syntax_set.I currently don't plan on making
ThemeSetlazy-loaded, because the impact of that is negligible compared to other things we can do. But in case we want to do it later, it's nice to have the code prepared like this.