Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract some private submodules from 'bat::assets' #1850

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Sep 13, 2021

As I continued working on #951, src/assets.rs grew uncomfortably large. So I figured it would be a good idea to first split it up into private submodules without changing the public API.

This is ready for detailed review, but as usual I'd like to do some final verification before merge.

(I use this hacky command to verify that the public API is not changed:

% rm -f /tmp/all-*.html && for commit in master introduce-internal-assets-submodules; do git ch $commit && cargo clean -p bat && cargo doc --no-deps --all-features && cp target/doc/bat/all.html /tmp/all-$commit.html; done && diff -u /tmp/all-*.html | diff-so-fancy

)

@Enselic
Copy link
Collaborator Author

Enselic commented Sep 13, 2021

Sorry for the last minute addition, but I got some extra time this evening to also throw in ignored_suffixes.rs in this PR. I know from continued prototyping on #951 that it will be useful to have this code generic, so it can be reused in MinimalAssets.

@Enselic
Copy link
Collaborator Author

Enselic commented Sep 15, 2021

I'll go ahead and merge this now since:

  • Keeping it open has quite high risk of conflicts
  • I'm happy with the code
  • Keith is happy with the code :)

@Enselic Enselic merged commit e84b702 into sharkdp:master Sep 15, 2021
@Enselic Enselic deleted the introduce-internal-assets-submodules branch September 15, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants