Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD: Add check for accidental inclusion of GPL:ed code #1961

Merged
merged 1 commit into from
Nov 28, 2021
Merged

CICD: Add check for accidental inclusion of GPL:ed code #1961

merged 1 commit into from
Nov 28, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Nov 28, 2021

I have confirmed that the script catches the problem that #1960 fixes.

sharkdp
sharkdp approved these changes Nov 28, 2021
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Enselic
Copy link
Collaborator Author

Enselic commented Nov 28, 2021

I have also confirmed now that the CI check would have failed for the initial version of #1959 (and also that the fix makes the check pass)

@Enselic Enselic merged commit ce89fb2 into sharkdp:master Nov 28, 2021
@Enselic Enselic deleted the add-gpl-license-check branch November 28, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enselic @sharkdp