Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum supported rust version to 1.51 #1994

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Set minimum supported rust version to 1.51 #1994

merged 1 commit into from
Dec 30, 2021

Conversation

mdibaiee
Copy link
Contributor

No description provided.

@mdibaiee mdibaiee mentioned this pull request Dec 29, 2021
Merged
sharkdp
sharkdp approved these changes Dec 29, 2021
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as per the discussion in the linked PR

@sharkdp
Copy link
Owner

sharkdp commented Dec 29, 2021

Hm, the clippy CI step shows warnings:

warning: lint `clippy::unknown_clippy_lints` has been removed: this lint has been integrated into the `unknown_lints` rustc lint

mdibaiee added a commit to mdibaiee/bat that referenced this pull request Dec 29, 2021
@mdibaiee
remove clippy::unknown_clippy_lints from cicd
a3d1fcc 
See sharkdp#1994 (comment)
@sharkdp
Copy link
Owner

sharkdp commented Dec 29, 2021

Thank you for the update. Could you please also update the various README files (search for 1.46)? And add an entry to the CHANGELOG.md?

Enselic
Enselic reviewed Dec 29, 2021
View reviewed changes
.github/workflows/CICD.yml Outdated Show resolved Hide resolved
Enselic
Enselic approved these changes Dec 29, 2021
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me know. Thanks for taking care of this!

@mdibaiee
Copy link
Contributor Author

mdibaiee commented Dec 29, 2021 •
edited
Loading

Thanks for the quick turnaround!

@Enselic Enselic merged commit 6dc621e into sharkdp:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdibaiee @sharkdp @Enselic