Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax: [Log] highlight escape characters in double quoted strings #2127

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Syntax: [Log] highlight escape characters in double quoted strings #2127

merged 1 commit into from
Mar 23, 2022

Conversation

keith-hall
Copy link
Collaborator

Fixes #2123

Enselic
Enselic approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure what's up with CI fail, colors looks unchanged, probably just need to update expected output.

@keith-hall
Copy link
Collaborator Author

Turned out I hadn't managed to re-create the binary asset dump locally - it failed checking out a submodule for Dart initially. Worked around it for now by removing that submodule locally :D

@sharkdp
Copy link
Owner

sharkdp commented Mar 23, 2022

Thanks!

@keith-hall keith-hall merged commit 1b030dc into master Mar 23, 2022
@keith-hall keith-hall deleted the log_syntax_2123 branch March 23, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[log syntax] Escaped quotes messes up colors inside of the json string.
3 participants
@keith-hall @sharkdp @Enselic