Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax glibc requirements on x86_64-unknown-linux-gnu #2194

Merged
merged 2 commits into from
May 16, 2022
Merged

Relax glibc requirements on x86_64-unknown-linux-gnu #2194

merged 2 commits into from
May 16, 2022

Conversation

sharkdp
Copy link
Owner

@sharkdp sharkdp commented May 16, 2022 •
edited
Loading

The Docker images used by cross use very old versions of glibc, so we can simply "cross" compile to fix #2106.

Before (binary from a recent master build):

▶ objdump -T bat|rg 'GLIBC_2.[0-9][0-9]'      
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.29) log
0000000000000000  w   DF *UND*	0000000000000000 (GLIBC_2.18) __cxa_thread_atexit_impl
0000000000000000  w   DF *UND*	0000000000000000 (GLIBC_2.25) getrandom
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.15) posix_spawnp
0000000000000000  w   DF *UND*	0000000000000000 (GLIBC_2.28) statx
0000000000000000  w   DF *UND*	0000000000000000 (GLIBC_2.29) posix_spawn_file_actions_addchdir_np
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.17) clock_gettime
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.14) memcpy

This PR:

▶ objdump -T bat|rg 'GLIBC_2.[0-9][0-9]'      
0000000000000000  w   DF *UND*	0000000000000000 (GLIBC_2.18) __cxa_thread_atexit_impl
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.14) memcpy
0000000000000000      DF *UND*	0000000000000000 (GLIBC_2.15) posix_spawnp

closes #2106

@sharkdp
Use cross to build x86_64-unknown-linux-gnu executables
40972e2 
We do this in order to link against older versions of glibc.

closes #2106
@sharkdp
Add CHANGELOG entry
332d084
Enselic
Enselic approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@sharkdp sharkdp merged commit 892b186 into master May 16, 2022
@sharkdp sharkdp deleted the link-older-glibc branch May 16, 2022 19:54
@phil-blain phil-blain mentioned this pull request Jul 6, 2022
Open
@kabouzeid kabouzeid mentioned this pull request Jan 31, 2023
Closed
@dandavison dandavison mentioned this pull request Apr 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLIBC 2.29 required by bat_0.20.0_amd64.deb
2 participants
@sharkdp @Enselic