Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VimHelp.sublime-syntax and its test #2366

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add VimHelp.sublime-syntax and its test #2366

merged 1 commit into from
Nov 4, 2022

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Oct 12, 2022

screen-2022-10-30-13-22-55

@sharkdp
Copy link
Owner

sharkdp commented Oct 30, 2022

Please also follow the usual practices here (see comments in your other PR)

@sharkdp
Copy link
Owner

sharkdp commented Oct 30, 2022

Also, I'm not sure if this satisfies our policies for syntax inclusion: https://github.com/sharkdp/bat/blob/master/doc/assets.md#Criteria-for-inclusion-of-new-syntaxes

@Freed-Wu
Copy link
Contributor Author

More than 10,000 downloads at Package Control

I think sublime users have no any need to view a vimhelp file 😄

@sharkdp
Copy link
Owner

sharkdp commented Oct 30, 2022

Fair point, but I also fail to see why someone would want to view a vim help text in bat, and not in vim directly

@Freed-Wu
Copy link
Contributor Author

less is a pager and vim is an editor. If users just want to take a look at a file, they can just less it.

@sharkdp
Copy link
Owner

sharkdp commented Nov 2, 2022

Yeah but... if I feel the need to look at vims help texts, I'm usually already inside vim - no?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Nov 3, 2022

if I feel the need to look at vims help texts, I'm usually already inside vim

Maybe any one who need to look at vimhelp install vim in their machine and can
use vim to look at helpfile, however, it only be convenient for those helpfiles
have been installed. For a vim plugin users don't ensure should they install,
before installation, use less to see it is also a reasonable situation.

BTW, I think vimhelp for vim is like orgmode for emacs, and bat have supported
orgmode, so perhaps vimhelp can be supported, too.

@sharkdp
Copy link
Owner

sharkdp commented Nov 4, 2022

Ok 😄

Thank you for your contribution. In the future, please open an issue first before you invest a lot of time in things that might not be accepted into bat in the end.

@sharkdp sharkdp merged commit accc1b6 into sharkdp:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants