Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No duplicate keys test #2646

Closed
wants to merge 6 commits into from

Conversation

YeungOnion
Copy link
Contributor

Addresses #2643

The test panic's at first instance of duplicate and emits string identifying the pattern. Is there an option to emit information for the duplicate beyond cargo test no_duplicate_builtin_keys -- --nocapture?

Don't think this will change, but this discussion on ripgrep/globset mentioned impl Eq for Glob

Add a mapping to use `Rust` for rusty object notation, identified by `.ron` extension. See [sharkdp#2427](sharkdp#2427).
since only implement Eq and not Ord for Glob, inspects all pairs.
Fails on first duplicate found as wouldn't expect to be adding large
number of syntaxes at once and emits the glob string pattern duplicated.
@YeungOnion
Copy link
Contributor Author

"it works on my machine!"

The new test I added is failing, but I tested that it worked and failed locally, but more importantly I can see output from the test when I have duplicate entries.

How might I display the output for this unit test? Or how might I debug what's different? I don't see any diff from SyntaxMapping::builtin even after removing the RON syntax.

@keith-hall
Copy link
Collaborator

"it works on my machine!"

The new test I added is failing, but I tested that it worked and failed locally, but more importantly I can see output from the test when I have duplicate entries.

How might I display the output for this unit test? Or how might I debug what's different? I don't see any diff from SyntaxMapping::builtin even after removing the RON syntax.

Presumably this could happen if, in CI, XDG_CONFIG_HOME == $HOME/.config. Perhaps changing that to only insert the "git config" mapping for the latter if the path differs from the former could fix it?

branched from wrong commit

This reverts commit fbd8049.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants