Add support for wildcards in Windows CMD #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your contribution! The code changes look good. Unfortunately, I just merged #327 which moved around some code. Could you please resolve the merge conflicts? Let me know if you need help. |
Windows does not support wildcard expansion in cmd, this adds 'wild' crate that handles everything transparently, so wildcards work everywhere. Fixes sharkdp#309
|
I rebased and resolved the conflicts. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not support wildcard expansion in cmd,
this adds 'wild' crate (as discussed in #309) that handles everything transparently,
so wildcards work everywhere.
Fixes #309