Add new style component to separate multiple '--line-range's #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry. I completely forgot about this PR. This looks really cool and I would like to merge this, but I didn't have time to look into the changes in detail. |
|
No worries! Take your time, the PR isn't going to disappear anywhere. |
|
(rebased to fix the merge conflicts) I finally had a closer look at this. This is awesome 👍 |
sharkdp
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My solution to my own issue, #569.
Reasoning
When specifying multiple line ranges with
--line-range=... --line-range=..., the printed lines tend to blend together and make it difficult to determine the scope of each range.Example which makes parts of three functions look as though they're a single function:
Implementation
The "snip" separator is implemented as another style component much like header and grid. I chose to include it in the
fullstyle by default, since doing otherwise would no longer make it "full".When not using the
fullstyle, it can be added assnip.Preview