Split long long lines into slices. #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2020
|
Labeling as needs-work since there are quite big conflicts that needs to be sorted out at the moment. I took a shot at it, but it was too tricky for a quick rebase. |
Enselic
reviewed
Dec 9, 2021
|
|
||
| use content_inspector::{self, ContentType}; | ||
|
|
||
| use crate::errors::*; | ||
|
|
||
| const THEME_PREVIEW_FILE: &[u8] = include_bytes!("../assets/theme_preview.rs"); | ||
| const MAXIMUM_LINE_LENGTH: usize = 1024 * 1024; | ||
|
|
||
| /// This function is like the read until present in the standard library |
There was a problem hiding this comment.
If someone picks this PR up: There is no need to duplicate this function. We can use take() instead. See https://github.com/sharkdp/bat/pull/1972/files#r763022008
|
I'm closing this now to keep our PR inbox clean and easy to get an overview of. I explicitly mentioned in #636 that anyone looking to fix this issue should also take a look at this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #636
Now lines are read using the buffer of BufRead.
I added an enum to set if the current line is an entire line or a subpart.
(If a line is longer than 1024*1024 the highlight does not work as expected)