Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapping method to support multiple print-width characters #815

Merged
merged 5 commits into from
Feb 28, 2020
Merged

Fix wrapping method to support multiple print-width characters #815

merged 5 commits into from
Feb 28, 2020

Conversation

Kogia-sima
Copy link
Contributor

Fix #787 and #811

@Kogia-sima Kogia-sima changed the title Feature/unicode wrap Fix wrapping method to support multiple print-width characters Feb 1, 2020
@Kogia-sima Kogia-sima force-pushed the feature/unicode-wrap branch from 661a9d5 to 1934c29 Compare February 1, 2020 11:28
@eth-p
Copy link
Collaborator

eth-p commented Feb 1, 2020

Awesome work, thanks for implementing this!

@eth-p eth-p added the feature-request New feature or request label Feb 26, 2020
@sharkdp
Copy link
Owner

sharkdp commented Feb 27, 2020

@Kogia-sima Thank you very much for your contribution!

Sorry for being pedantic about this, but what is the content of the text that you added as (unit) tests? I'd appreciate if that would be something that is (1) "neutral" in terms of content and (2) uncritical with respect to licensing.

Maybe it would be best to use some very stupid meaningless dummy text, possibly repeating one and the same word (i.e. without reusing any existing text).

@Kogia-sima
Update test data
7fc327c 
Avoid using existing text
@Kogia-sima
Copy link
Contributor Author

Kogia-sima commented Feb 28, 2020 •
edited
Loading

@sharkdp Those texts are cited from here.

I don't know whether those texts are suitable for MIT/Apache-2.0 license, but it might include affiliated contents. Anyway, I've replaced the input data with the texts which does not reuse any existing sentence.

@sharkdp sharkdp merged commit 60f48a0 into sharkdp:master Feb 28, 2020
@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2020

@Kogia-sima Thank you for the update and thank you for implementing this!

@sharkdp sharkdp mentioned this pull request Feb 28, 2020
Closed
@sharkdp
Copy link
Owner

sharkdp commented Mar 22, 2020

This has been released in bat 0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapping characters spanning multiple print-width
3 participants
@Kogia-sima @eth-p @sharkdp