Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ignore to 0.3, ansi_term to 0.10 #173

Closed
wants to merge 2 commits into from

Conversation

ignatenkobrain
Copy link

No description provided.

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@sharkdp
Copy link
Owner

sharkdp commented Nov 20, 2017

Hi,

Thank you for your contribution! Is there any particular reason why you would like to update these dependencies?

Currently, the build fails on Windows. This is a known bug with ansi_term and has already been addressed upstream (ogham/rust-ansi-term#31) by @iology.

@ignatenkobrain
Copy link
Author

@sharkdp I'm packaging fd-find for Fedora and we try to keep only latest versions of crates as long as it's possible. I can keep those bumps as our downstream patches until someone fixes ansi-term.

@sharkdp
Copy link
Owner

sharkdp commented Nov 22, 2017

I see. I'm afraid this is the only option for now, as we would like to keep supporting all platforms that are tested via CI.

I'm packaging fd-find for Fedora

Thank you very much!

@sharkdp sharkdp closed this Nov 22, 2017
@sharkdp
Copy link
Owner

sharkdp commented Mar 13, 2018

Both ignore as well as ansi_term have now been updated to the latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants