Support colorless help #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanonid
force-pushed
the
support_colorless_help
branch
from
e1b8215
to
d1c0e4f
Compare
sharkdp
requested changes
Oct 25, 2020
src/app.rs
Outdated
| @@ -1,10 +1,17 @@ | |||
| use clap::{crate_version, App, AppSettings, Arg}; | |||
|
|
|||
| pub fn build_app() -> App<'static, 'static> { | |||
| let clap_color_setting = | |||
| if atty::is(atty::Stream::Stdout) && std::env::var_os("NO_COLOR").is_none() { | |||
There was a problem hiding this comment.
I think clap does an isatty check internally, because fd --help | cat is not colored at the moment. So I guess we could remove the atty::is(…) part here (as well as the build dependency)
There was a problem hiding this comment.
isatty check removed (and rebased).
xanonid
force-pushed
the
support_colorless_help
branch
from
d1c0e4f
to
7a32e33
Compare
sharkdp
approved these changes
Dec 1, 2020
|
Nevermind, I will add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #600