Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export intermediate results after each benchmark command #339

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

s1ck
Copy link
Contributor

@s1ck s1ck commented Oct 17, 2020

fixes #306

I took a very simple approach, by just exporting all benchmark results after each benchmark command has run. It re-creates the file, but still allows using e.g. tail -f.

Please let me know if this fits the requirements, happy to work on a more sophisticated implementation, e.g. opening the file and trying to append individual results, however, this becomes a bit more complicated for json I assume.

@sharkdp
Copy link
Owner

sharkdp commented Oct 17, 2020

Thank you very much for your contribution!

I took a very simple approach, by just exporting all benchmark results after each benchmark command has run. It re-creates the file

That's actually what I suggested in #313, in case you have not seen that.

Please let me know if this fits the requirements, happy to work on a more sophisticated implementation, e.g. opening the file and trying to append individual results, however, this becomes a bit more complicated for json I assume.

I guess it's not even possible to generate always-valid JSON files this way, as they would need some sort of closing array ] and/or record }.

It re-creates the file, but still allows using e.g. tail -f.

The Markdown export shows relative times in one column. These relative times can change as new benchmark results come in. So using tail -f won't really work in that case, but that's completely fine, I guess.

Could you please add an entry to the "unreleased" section in CHANGELOG.md? The format for entries is:

- Description what has been changed, see #123 (@user)

where #123 links to the bug ticket and/or the PR and user is your username.

@s1ck
Copy link
Contributor Author

s1ck commented Oct 17, 2020

Sorry, I haven't checked #313 as there was no PR linked to the issue. Reading it now and it's nice that you came to the same conclusion which is "the export should be so fast that it doesn't really matter" :)

@sharkdp sharkdp merged commit 2547342 into sharkdp:master Oct 18, 2020
@sharkdp
Copy link
Owner

sharkdp commented Oct 18, 2020

Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing intermediate results
2 participants