Create export file before first benchmark #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Oct 17, 2020
| @@ -55,7 +55,9 @@ impl ExportManager { | |||
| } | |||
|
|
|||
| /// Add an additional exporter to the ExportManager | |||
| pub fn add_exporter(&mut self, export_type: ExportType, filename: &str) { | |||
| pub fn add_exporter(&mut self, export_type: ExportType, filename: &str) -> Result<()> { | |||
| let _ = File::create(filename)?; | |||
There was a problem hiding this comment.
Another idea could be to open the file here (in write-mode, as below) and store the file handle with the exporter - instead of (or in addition to) the filename.
There was a problem hiding this comment.
Good idea. If we add file: File to the struct, we however need to use the ExportManager as &mut everywhere since we need a &mut self in write_results. It works, but requires more changes. Did you think of a different way?
There was a problem hiding this comment.
Let's leave it as it is for now - thank you!
|
Thank you, this looks great. I have one comment, but I'm also okay with leaving it as it is, if you prefer. Could you please also adapt the CHANGELOG (see your other PR)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306
A second request in #306 was to check if the file specified by the
--export-*options is accessible. In this PR, we create the file when theExportManageris initialized and just open it inwritemode when writing the results.