Bug: correct passing quoted arguments to Windows CMD #678
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PedroWitzel Thank you very much for your contribution! @rivy Any chance you could take a look at this? You seemed very knowledgeable in this area.. and I personally don't even have a Windows machine. If not, that's also fine of course! |
sharkdp
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296
Applied the proposed change to used
raw_argwhen passing args on the command builder.Added two tests cases:
\just before the ending"induces different parsing in different environments.They were failing before the correction, but now are OK.
N.B.: new rustacean, all inputs are welcomed 😅