-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: handle query string input line by line #206
Conversation
Thank you very much. It handles multi-line inputs like @aliases(points)
unit point correctly because those can be combined into a single line (
because the combination This is why I previously opted for the "combine everything into one block" solution. I want to introduce semicolons eventually, but those wouldn't help either because we do not want to introduce a semicolon to join lines in the first example above. We would need help from the parser to know where to potentially split. What might work is to have some special symbol just for encoding inputs in the URL. Maybe something like |
3334dad
to
7f4ea15
Compare
Ahh, yes, this doesn't handle that type of multi-line input. I'll implement your idea with Though I guess it's worth clarifying if you think the issue I reported in #205 is actually an issue worth fixing. I think maybe someone could argue successfully that the current behavior is desired (or maybe even preferred, because it produces a more compact output) |
Yes, absolutely!
On the other hand, we are currently hiding some results. So yours is the better option, in my opionion. |
This changes how input from a query string are handled. Handling them line by line produces output that more closely resembles how it would have looked like when typed in interactively. Closes sharkdp#205
7f4ea15
to
08cbb32
Compare
Sorry for the delay here. I've rebased and pushed a commit that adopts the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This changes how input from a query string are handled. Handling them line by line produces output that more closely resembles how it would have looked like when typed in interactively.
Note that this is technically a breaking change: existing numbat.dev URLs in the wild that contain newlines in the middle of statements will no longer work.
Closes #205