Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI config file #227

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Add CLI config file #227

merged 10 commits into from
Nov 9, 2023

Conversation

triallax
Copy link
Contributor

@triallax triallax commented Nov 4, 2023 •
edited by sharkdp
Loading

Fixes #97, fixes #139.

TODO:

  • Add documentation

@triallax triallax marked this pull request as draft November 4, 2023 22:59
triallax
triallax commented Nov 4, 2023
View reviewed changes
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
@triallax triallax force-pushed the add-config-file branch 2 times, most recently from 7e3038b to 585dc83 Compare November 6, 2023 20:04
triallax
triallax commented Nov 6, 2023
View reviewed changes
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Nov 6, 2023
View reviewed changes
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Nov 6, 2023
View reviewed changes
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp requested changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool — thank you very much!

sharkdp
sharkdp reviewed Nov 8, 2023
View reviewed changes
numbat-cli/src/main.rs Outdated Show resolved Hide resolved
@sharkdp sharkdp marked this pull request as ready for review November 9, 2023 19:28
@sharkdp sharkdp merged commit b6fbf9a into master Nov 9, 2023
14 checks passed
@sharkdp sharkdp deleted the add-config-file branch November 9, 2023 20:11
@p-linnane p-linnane mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customizing behavior of exchange rate fetching User configuration
2 participants
@triallax @sharkdp