Add #[track_caller] annotation to some panicy VM functions #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error messages a bit if the the panics are triggered in these functions
While adding new code into vm.rs, I often got the order of the stack mixed up, and would run into one of the panics like
pop_quantity()
"Expected quantity to be on the top of the stack"Without
#[track_caller]
, the line number printed in the error message would be the line of the call topanic!()
. But with#[track_caller]
, the line number now points to the caller of thepop_xyz()
function, which is a bit more useful