Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add clippy job to check for linting issues #355

Closed
wants to merge 1 commit into from
Closed

ci: add clippy job to check for linting issues #355

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link
Contributor

No description provided.

runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
- run: cargo clippy -- --allow clippy::result_large_err --deny warnings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we could protect against other linting issues in the meantime.

@triallax
Copy link
Contributor

Can you please revert the gratuitous style changes?

@sharkdp
Copy link
Owner

sharkdp commented Feb 18, 2024

I'd rather not have this as a blocking CI check, to be honest.

@hamirmahal
Copy link
Contributor Author

Okay, it's up to you.

@hamirmahal hamirmahal closed this Feb 18, 2024
@hamirmahal hamirmahal deleted the ci/check-for-linting-issues branch February 18, 2024 20:21
@hamirmahal hamirmahal mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants