feat: create directories for history if they DNE #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Mar 5, 2024
numbat-cli/src/main.rs
Outdated
| history_path.to_string_lossy() | ||
| ))?; | ||
| // Try to save the history, and if it fails because prerequisite directories don't exist, create them. | ||
| if let Err(e) = rl.save_history(&history_path) { |
There was a problem hiding this comment.
Instead of checking whether it fails, we could always call create_dir_all.
There was a problem hiding this comment.
Oh, that could be much cleaner.
There was a problem hiding this comment.
Let me know if the latest changes are more or less what you had in mind.
if they don't exist, already
|
We actually have a call to I changed the fix to use |
sharkdp
approved these changes
Mar 9, 2024
hamirmahal
deleted the
feat/create-directories-for-history-if-they-dont-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #385.