Change error message for unterminated strings with interpolation. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was exploring the codebase when I stumbled into what seemed to be the cause of #314.
The parser section handling interpolated strings would error out as UnterminatedStringInterpolation but it was effectively checking for unterminated strings. I couldn't really find a case where the tokenizer would be unable to catch an unterminated interpolation where it wasn't also a case of an unterminated string (let me know if there is one.)
For reference, here's the error message behavior with this PR:
There might be more edge cases with newlines. The error messages seems mostly fine as is, but the last one is maybe a bit weird:
