Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new heat energy units #495

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Add new heat energy units #495

merged 7 commits into from
Jul 26, 2024

Conversation

MugheesQasim
Copy link
Contributor

Closes #471

@sharkdp
Copy link
Owner

sharkdp commented Jul 16, 2024

Thank you. You can fix the doc build by following the suggestion in the CI job:

Make sure to run 'build.py' in the book/ folder

@MugheesQasim
Copy link
Contributor Author

Thanks for the comment. PR is good to merge now.

@@ -62,6 +62,8 @@ assert_eq(8e-15, 8 ppq, 1e-16)

assert_eq(1 calorie, 4.184 J)
assert_eq(1 BTU, 1055.05585262 J)
assert_eq(1 therm, 1.05505585262e8 J)
assert_eq(1 thermie, 4.184e6 J)
Copy link
Owner

@sharkdp sharkdp Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually different from the value quoted on Wikipedia:

The thermie is equivalent to 1000 kcal, 4.1868 MJ or 3968.3 BTU.

I think Wikipedia might be wrong here since their values are contradictory. According to their own linked article, 1 kcal = 4.184 J, so if 1 thermie = 1000 kcal, then 1 thermie = 4.184 MJ.

The 4.1868 value refers to some older definition of the calorie (International Steam Table calorie, 1929 and 1956).

And the only source that they quote on the Thermie article is https://www.cnrtl.fr/definition/thermie, which also has a value of 4.184 MJ.

Copy link
Owner

@sharkdp sharkdp Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a discussion on the Talk:Thermie page:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This publication might also give some insight: Publication:Calorie (Specifically, pages 106 and 107)

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sharkdp sharkdp merged commit 0b8453e into sharkdp:master Jul 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add heat energy units therm and thermie
3 participants