-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new heat energy units #495
Conversation
Thank you. You can fix the doc build by following the suggestion in the CI job:
|
Thanks for the comment. PR is good to merge now. |
@@ -62,6 +62,8 @@ assert_eq(8e-15, 8 ppq, 1e-16) | |||
|
|||
assert_eq(1 calorie, 4.184 J) | |||
assert_eq(1 BTU, 1055.05585262 J) | |||
assert_eq(1 therm, 1.05505585262e8 J) | |||
assert_eq(1 thermie, 4.184e6 J) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is actually different from the value quoted on Wikipedia:
The thermie is equivalent to 1000 kcal, 4.1868 MJ or 3968.3 BTU.
I think Wikipedia might be wrong here since their values are contradictory. According to their own linked article, 1 kcal = 4.184 J, so if 1 thermie = 1000 kcal, then 1 thermie = 4.184 MJ.
The 4.1868 value refers to some older definition of the calorie (International Steam Table calorie, 1929 and 1956).
And the only source that they quote on the Thermie article is https://www.cnrtl.fr/definition/thermie, which also has a value of 4.184 MJ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a discussion on the Talk:Thermie page:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This publication might also give some insight: Publication:Calorie (Specifically, pages 106 and 107)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #471