Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow closing parens and newlines #513

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Allow closing parens and newlines #513

merged 3 commits into from
Jul 28, 2024

Conversation

irevoire
Copy link
Contributor

Fixes #507

sharkdp
sharkdp reviewed Jul 28, 2024
View reviewed changes
numbat/src/parser.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp requested changes Jul 28, 2024
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Just one minor comment

@irevoire irevoire requested a review from sharkdp July 28, 2024 18:03
@sharkdp sharkdp merged commit 8c5e63d into sharkdp:master Jul 28, 2024
15 checks passed
@irevoire irevoire deleted the allow-closing-parens-and-newlines branch July 28, 2024 18:44
@BrewTestBot BrewTestBot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow closing parens (and trailing comma?) in function calls to be on the next line
2 participants
@irevoire @sharkdp