Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow units with rational exponents #614

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Allow units with rational exponents #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion numbat/src/unit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl UnitIdentifier {

// Multiply by the product of all divisors to make all exponents
// integers. This is needed for the next step.
let factor: i128 = key.iter().map(|p| p.1.numer()).product();
let factor: i128 = key.iter().map(|p| p.1.denom()).product();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea (comment above) was correct, the execution was not 😄


key.iter_mut().for_each(|p| p.1 *= factor);

Expand Down
Loading