String api update #646
Merged
String api update #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Nov 3, 2024
sharkdp
reviewed
Nov 3, 2024
sharkdp
reviewed
Nov 3, 2024
sharkdp
reviewed
Nov 3, 2024
|
Thank you! |
|
Thank you for the review, I agree on all counts. I think the color function especially was a good call and got much easier to understand after the change. |
Merged
Goju-Ryu
force-pushed
the
string-api-update
branch
from
510e0eb
to
7f3cb64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #628 by reordering arguments of all string functions.
With this PR all string functions have the string being manipulated as the last argument.