Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if this comes across as low-effort. On potentially new projects, I like to turn on pedantic lints, and go through what comes out and see what little chores I can help with. It gives me a chance to familiarise my self with the projects contribution work flow, as well as get a start at looking at the code base.
The bulk of the lints are merging of the match statements.
There is also (according to the lint) a minor performance gain when using an
&&str
type:(*the_str).to_string()
is better thanthe_str.to_string()
.There are some other lints that promise to be minor micro-optimisations, but they change the interface (mostly about arguments being references vs owned).
If you want, I can also make changes to the private functions where clippy suggests these api changes.