Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ma.log10 instead of np.log10 in interp.hght() #168

Closed
ahijevyc opened this issue Jun 18, 2019 · 1 comment
Closed

use ma.log10 instead of np.log10 in interp.hght() #168

ahijevyc opened this issue Jun 18, 2019 · 1 comment

Comments

@ahijevyc
Copy link

Should ma.log10() be used at the end of the interp.hght() function instead of np.log10()?

return generic_interp_pres(ma.log10(p), prof.logp[::-1], prof.hght[::-1])

I would like to avoid the log10 of zero warning, but don't want to break anything. I tried a pull request, but couldn't figure out how to isolate this change from the rest of my changes.

@wblumberg
Copy link
Contributor

Hi @ahijevyc

I went ahead and incorporated this change into Andover. It passed all the tests, so it doesn't look like it's going to disrupt anything! Thanks for the recommendation.

Greg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants