Check all directories exist #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A possible failure mode is accidentally adding a path that does not exist to the PATH. Another failure mode is adding the file such as `bin/yarn` instead of the directory `bin`. This check guarantees that the directory exists and that it is in fact a directory.
schneems
force-pushed
the
schneems/check-dirs-exist
branch
from
3dd3e4e to
fb313ed
Compare
|
On the Ruby buildpack i'm seeing this on the PATH: I don't know where the I'm tired of looking at this for now, i'm going to put a pin in it. We should perhaps re-visit. For now it can't be applied without breaking the Ruby buildpack tests and its unclear there's benefit from fixing this immediate issue. It would be good to get it out of the PATH, but dealing with the bash bootstrapping process is 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible failure mode is accidentally adding a path that does not exist to the PATH. Another failure mode is adding the file such as
bin/yarninstead of the directorybin. This check guarantees that the directory exists and that it is in fact a directory.