Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unneccessary stopIterationException #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed Unneccessary stopIterationException #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions giphypop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,16 @@ def search(self, term=None, phrase=None, limit=DEFAULT_SEARCH_LIMIT,
yield GiphyImage(item)

if limit is not None and results_yielded >= limit:
raise StopIteration
break
#Exception is not required and requires unneccessary try except block
# raise StopIteration

# Check yieled limit and whether or not there are more items
if (page >= data['pagination']['total_count'] or
(limit is not None and results_yielded >= limit)):
raise StopIteration
break
#Exception is not required and requires unneccessary try except block
# raise StopIteration

def search_list(self, term=None, phrase=None, limit=DEFAULT_SEARCH_LIMIT,
rating=None):
Expand Down