Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix connection loss issue #54

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/csharp/src/ZooKeeperNetEx/utils/SocketContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public SocketAsyncOperation GetResult()

var socketAsyncEventArgs = _socketAsyncEventArgs;

if (socketAsyncEventArgs.LastOperation == SocketAsyncOperation.Receive && _socket.Available == 0)
if (socketAsyncEventArgs.LastOperation == SocketAsyncOperation.Receive
&& _socket.Available == 0
&& !IsSocketConnected())
{
socketAsyncEventArgs.SocketError = SocketError.ConnectionReset;
}
Expand All @@ -85,6 +87,25 @@ public SocketAsyncOperation GetResult()
}
return socketAsyncEventArgs.LastOperation;
}

private bool IsSocketConnected()
{
// based on https://learn.microsoft.com/en-us/dotnet/api/system.net.sockets.socket.connected

var originalBlockingState = _socket.Blocking;
try
{
_socket.Blocking = false;
_socket.Send(new byte[1], size: 0, SocketFlags.None);
}
catch (SocketException) { }
finally
{
_socket.Blocking = originalBlockingState;
}

return _socket.Connected;
}

private void ThrowIfDisposed()
{
Expand Down