test: add fuzz testing #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheerlox
force-pushed
the
test/fuzzing
branch
from
ae23309
to
0947d7e
Compare
sheerlox
pushed a commit
that referenced
this pull request
Oct 21, 2023
## [1.0.2](v1.0.1...v1.0.2) (2023-10-21) ### 🛠 Builds * configure and run knip ([0f38051](0f38051)) ### 📚 Documentation * add PURPOSE.md ([13e24f9](13e24f9)) ### 🚨 Tests * add fuzz testing ([#18](#18)) ([9abddb5](9abddb5)) ### ⚙️ Continuous Integrations * **action:** enable ossf scorecard repo_token ([390edd7](390edd7)) * **action:** update actions/checkout action to v4.1.1 ([#23](#23)) ([fcdb52c](fcdb52c)) * **action:** update actions/checkout digest to b4ffde6 ([#24](#24)) ([93c99ed](93c99ed)) * **action:** update github/codeql-action action to v2.22.2 ([#17](#17)) ([7d49e7f](7d49e7f)), closes [#9](#9) * **action:** update github/codeql-action action to v2.22.3 ([#20](#20)) ([3611086](3611086)), closes [#9](#9) * **action:** update github/codeql-action action to v2.22.3 ([#21](#21)) ([45faedc](45faedc)) * **action:** update github/codeql-action action to v2.22.4 ([#25](#25)) ([fe13382](fe13382)) ### ♻️ Chores * **deps:** lock file maintenance ([#22](#22)) ([8d686b1](8d686b1)) * **deps:** pin dependency [@fast-check](https://github.com/fast-check)/ava to 1.1.6 ([#19](#19)) ([a82bbb2](a82bbb2)) * remove ossf scorecard fast-check detection hack ([ca95e03](ca95e03))
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though process
First tried to implement a "real" fuzzing test with
@jazzer.js/coreand@jazzer.js/jest-runner(see Notes).Things were not working out as expected, so I came up with a working solution (see Solution).
Notes
.cifuzz-corpus/fuzz.test/importFrom/, and crashes are located intests/fuzzing/fuzz.test/importFrom/new FuzzedDataProvider(buffer).consumeString()method seems more performant thanbuffer.toString()(~15%) (in the standalone version, in Jest it's the opposite)Solution
Based on the above observations (difficulty, if not impossibility, to implement fuzzing libraries for ESM packages) and choices made by ossf/scorecard, the "fuzzing" process is using the
fast-checklibrary (or more specifically its@fast-check/avatest runner integration).Side notes
While working on this issue, I noticed
ossf/scorecarddidn't detectfast-checktest runners integrations correctly, so I've opened issue ossf/scorecard#3567 and submitted PR ossf/scorecard#3568 to fix that.In the meantime, I've added a "hack" import so
fast-checkgets detected correctly byossf/scorecard.