Skip to content

fix: parse escape sequences in pty_write input #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shekohex merged 1 commit into from
Dec 30, 2025
Merged

fix: parse escape sequences in pty_write input #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/plugin/pty/tools/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,28 @@ import { manager } from "../manager.ts";
import { checkCommandPermission } from "../permissions.ts";
import DESCRIPTION from "./write.txt";

/**
* Parse escape sequences in a string to their actual byte values.
* Handles: \n, \r, \t, \xNN (hex), \uNNNN (unicode), \\
*/
function parseEscapeSequences(input: string): string {
return input.replace(/\\(x[0-9A-Fa-f]{2}|u[0-9A-Fa-f]{4}|[nrt\\])/g, (match, seq: string) => {
if (seq.startsWith("x")) {
return String.fromCharCode(parseInt(seq.slice(1), 16));
}
if (seq.startsWith("u")) {
return String.fromCharCode(parseInt(seq.slice(1), 16));
}
switch (seq) {
case "n": return "\n";
case "r": return "\r";
case "t": return "\t";
case "\\": return "\\";
default: return match;
}
});
}

function extractCommands(data: string): string[] {
const commands: string[] = [];
const lines = data.split(/[\n\r]+/);
Expand Down Expand Up @@ -38,15 +60,18 @@ export const ptyWrite = tool({
throw new Error(`Cannot write to PTY '${args.id}' - session status is '${session.status}'.`);
}

const commands = extractCommands(args.data);
// Parse escape sequences to actual bytes
const parsedData = parseEscapeSequences(args.data);

const commands = extractCommands(parsedData);
for (const commandLine of commands) {
const { command, args: cmdArgs } = parseCommand(commandLine);
if (command) {
await checkCommandPermission(command, cmdArgs);
}
}

const success = manager.write(args.id, args.data);
const success = manager.write(args.id, parsedData);
if (!success) {
throw new Error(`Failed to write to PTY '${args.id}'.`);
}
Expand Down